chore(ui): migrate Modal to TypeScript #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b5defd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
barsukov
approved these changes
Oct 16, 2024
andypf
approved these changes
Oct 16, 2024
andypf
pushed a commit
that referenced
this pull request
Oct 17, 2024
* chore(ui): migrate Modal to TypeScript * fix(ui): lint fixes --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: Wowa Barsukov <[email protected]>
andypf
added a commit
that referenced
this pull request
Oct 17, 2024
* feat(docs): adds a brd for carbon app loading mechanism * Update docs/proposals/004_carbon_brd.md Co-authored-by: Esther Schmitz <[email protected]> * Update docs/proposals/004_carbon_brd.md Co-authored-by: Esther Schmitz <[email protected]> * Update docs/proposals/004_carbon_brd.md Co-authored-by: Esther Schmitz <[email protected]> * Update docs/proposals/004_carbon_brd.md Co-authored-by: Esther Schmitz <[email protected]> * fix(ui): fix broken pageheader layout (#506, #473) (#510) * fix(ui): fix broken PageHeader * fix(ui): fix story template * fix(ui): remove obsolete * fix(ui): fix story es-lint error remove explicit destructuring of children, leave type-checking to TypeScript * Create blue-news-wash.md * fix(ui): rename Pageheader story * fix(ui): always render heading div * fix(ui): prevent rendering null, false or undefined as page header title at all cost Fixes #506 , Fixes #473 --------- Co-authored-by: Wowa Barsukov <[email protected]> * chore(ui): migrate Modal to TypeScript (#524) * chore(ui): migrate Modal to TypeScript * fix(ui): lint fixes --------- Co-authored-by: [email protected] <[email protected]> Co-authored-by: Wowa Barsukov <[email protected]> * chore(docs): update carbon brd * chore(docs): fix formatting --------- Co-authored-by: Esther Schmitz <[email protected]> Co-authored-by: Franz Heidl <[email protected]> Co-authored-by: Wowa Barsukov <[email protected]> Co-authored-by: Grzegorz Jaśkiewicz <[email protected]> Co-authored-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
migrate Modal to TypeScript
Changes Made
Related Issues
Testing Instructions
npm iturbo testChecklist